Skip to content

test: switch to use common.fixtures.readKey #15814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UnrememberMe wants to merge 2 commits into from
Closed

test: switch to use common.fixtures.readKey #15814

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b088b1
test: switch to use common.fixtures.fixturesDir
UnrememberMe Oct 6, 2017
0437fd4
Remove intermediate calls and use fixtures.readKey directly.
UnrememberMe Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove intermediate calls and use fixtures.readKey directly. 
As per review feedback, there is already a function in common.fixture
that handles the logic of reading key files. Switch to use that.
  • Loading branch information
@UnrememberMe
UnrememberMe committed Oct 6, 2017
commit 0437fd43f8827295b03559f5d3099fbf68e21d1a
8 changes: 1 addition & 7 deletions test/parallel/test-https-strict.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,9 @@ process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';

const assert = require('assert');
const https = require('https');
const fs = require('fs');
const path = require('path');

function file(fname) {
return path.resolve(fixtures.fixturesDir, 'keys', fname);
}

function read(fname) {
return fs.readFileSync(file(fname));
return fixtures.readKey(fname);
}

// key1 is signed by ca1.
Expand Down