use fixtures#15805
Closed
boutell wants to merge 2 commits into
Closed
Conversation
pawelgolda
reviewed
Oct 6, 2017
| const serverOptions = { | ||
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`) | ||
| key: fs.readFileSync(fixtures.path('/keys/agent1-key.pem')), |
Contributor
There was a problem hiding this comment.
Consider using fixtures.readKey instead of fs.readFileSync to get the keys.
Author
|
@pawelgolda how about now? Thanks! |
rmg
approved these changes
Oct 6, 2017
cjihrig
reviewed
Oct 7, 2017
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
Does the linter complain about fs being unused now?
tniessen
approved these changes
Oct 7, 2017
Member
Contributor
|
Welcome @boutell and thank you for the contribution 🥇 The linter CI job found some lint in this PR: Hope you find the time to follow up. |
lpinca
reviewed
Oct 9, 2017
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| const fixtures = require('../common/fixtures'); |
Member
There was a problem hiding this comment.
Nit: can you please move this after the common.hasCrypto check? Thank you.
gireeshpunathil
approved these changes
Oct 10, 2017
Member
|
Went ahead and fixed the nits on landing |
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
PR-URL: #15805 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Landed in c29e366 |
Author
|
Thanks for the adjustments!
…On Oct 12, 2017 10:12 PM, "James M Snell" ***@***.***> wrote:
Closed #15805 <#15805>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15805 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAB9fURmWmkECETre06ZHlLitxzikR5aks5srscAgaJpZM4PwvVU>
.
|
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15805 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15805 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: use fixtures module
In test-https-server-keep-alive-timeout.js, replaced common.fixturesDir with use of the common.fixtures module as requested at nodejs interactive code & learn. Thanks!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)