Skip to content

Fix deprecation warnings #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 2 commits into from
May 4, 2015
Merged

Fix deprecation warnings #1577

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f696c9e
src: fix deprecated use of Buffer::New()
bnoordhuis May 1, 2015
2ed10f1
src: fix minor inefficiency in Buffer::New() call
bnoordhuis May 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: fix minor inefficiency in Buffer::New() call 
Commit ccb199a ("src: fix deprecation warnings") passes env()->isolate()
to the Buffer::New() call.  It's somewhat inefficient because the callee
looks up the environment from the isolate.  Just pass the env directly.

PR-URL: #1577
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed May 4, 2015
commit 2ed10f13492221da0e5d1795bb0c780308c08d48
6 changes: 3 additions & 3 deletions src/spawn_sync.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ void SyncProcessStdioPipe::Close() {
}


Local<Object> SyncProcessStdioPipe::GetOutputAsBuffer(Isolate* isolate) const {
Local<Object> SyncProcessStdioPipe::GetOutputAsBuffer(Environment* env) const {
size_t length = OutputLength();
Local<Object> js_buffer = Buffer::New(isolate, length);
Local<Object> js_buffer = Buffer::New(env, length);
CopyOutput(Buffer::Data(js_buffer));
return js_buffer;
}
Expand Down Expand Up @@ -679,7 +679,7 @@ Local<Array> SyncProcessRunner::BuildOutputArray() {
for (uint32_t i = 0; i < stdio_count_; i++) {
SyncProcessStdioPipe* h = stdio_pipes_[i];
if (h != nullptr && h->writable())
js_output->Set(i, h->GetOutputAsBuffer(env()->isolate()));
js_output->Set(i, h->GetOutputAsBuffer(env()));
else
js_output->Set(i, Null(env()->isolate()));
}
Expand Down
2 changes: 1 addition & 1 deletion src/spawn_sync.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class SyncProcessStdioPipe {
int Start();
void Close();

Local<Object> GetOutputAsBuffer(Isolate* isolate) const;
Local<Object> GetOutputAsBuffer(Environment* env) const;

inline bool readable() const;
inline bool writable() const;
Expand Down