Skip to content

test: check that this != new.target in addon #15681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 1 commit into from
Closed

test: check that this != new.target in addon #15681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: check that this != new.target in addon 
Add two checks that are there for expository reasons as much as they are
sanity checks.

Refs: nodejs/node-addon-api#142
  • Loading branch information
@bnoordhuis
bnoordhuis committed Sep 29, 2017
commit b24110a78152d34fe7f2b0452c4dd78a659be519
6 changes: 5 additions & 1 deletion test/addons/new-target/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@

namespace {

inline void NewClass(const v8::FunctionCallbackInfo<v8::Value>&) {}
inline void NewClass(const v8::FunctionCallbackInfo<v8::Value>& args) {
// this != new.target since we are being invoked through super().
assert(args.IsConstructCall());
assert(!args.This()->StrictEquals(args.NewTarget()));
}

inline void Initialize(v8::Local<v8::Object> binding) {
auto isolate = binding->GetIsolate();
Expand Down