Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[8.x backport] fs: add O_DSYNC flag (+ one other) #15653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[8.x backport] fs: add O_DSYNC flag (+ one other) #15653
Changes from 1 commit
69357d0670c2f4b5faadda872b97dc072272603466ab9d1e7119e05ffa07b270bd64f100d0c518f07f00150a1c49325095e04b70a5add5ff7cad8dd015756c43adec76c063f2d336d2afb3022f8032f8caa22c86f290e5dacd4696ae47f5b7fe48f889db101e6b64fab785b3577103f7db1c65ff235f095992a31997ccddd8b4492ccb8b0a8993d93528ebe12c08b32c319ab037208b150f9bb3e218c7b9d2ab20f702876f2fde76baeb46a70f60c9aabd84d083077b64d61d7322f75e01b54f7837fc996a42c8fd93e65d3eef8124a7ac6f5b211097e8c0fd54ee0ca92487685eef7288aafa9e482b0d70043c2557df19bae7811ffcd910fbc14d0cbcdfbc1e166bd7c6aaaf03142c2562c2802547fe58f72da3bcbe5d7ad954a82e4a06e65d4a9471604eb76ad3b9da5baa25e26ed8d930809df623c6371b2a5c7ae613236124901359cb9b8c9a4c2c85d7cc6b65cc8c7c7ad898d8f9ac43f7bfc7945dd9832c8db1b30530dd6ade271ccdcd325633608983f10e2f5470ef867611ed593f3d25ff4d0e2b22014e8b120fe9d97fccFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Original commit message: Work around glibc thread-local storage bug glibc before 2.17 has a bug that makes it impossible to execute binaries that have single-byte thread-local variables: % node --version node: error while loading shared libraries: cannot allocate memory in static TLS block Work around that by making the one instance in the V8 code base an int. See: https://sourceware.org/bugzilla/show_bug.cgi?id=14898 See: nodesource/distributions#513 See: nodejs/build#809 Change-Id: Iefd8009100cd93e26cf8dc5dc03f2d622b423385 Reviewed-on: https://chromium-review.googlesource.com/612351 Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47400} Backport-PR-URL: #15393 PR-URL: #14913 Ref: nodejs/build#809 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing