Skip to content

n-api: add check for large strings #15611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 3 commits into from
Closed

n-api: add check for large strings #15611

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fdd2e4
n-api: add check for large strings
mhdawson Sep 25, 2017
d319160
squash: address comments
mhdawson Sep 26, 2017
ff719da
squash: fix test failures on 32bit platforms
mhdawson Sep 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: fix test failures on 32bit platforms
  • Loading branch information
@mhdawson
mhdawson committed Sep 28, 2017
commit ff719da924abde9b38372d7e0f8814695578ed99
9 changes: 8 additions & 1 deletion test/addons-napi/test_string/test_string.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#include <limits.h> // INT_MAX
#include <node_api.h>
#include "../common.h"

Expand Down Expand Up @@ -203,7 +204,13 @@ napi_value Utf8Length(napi_env env, napi_callback_info info) {

napi_value TestLargeUtf8(napi_env env, napi_callback_info info) {
napi_value output;
NAPI_CALL(env, napi_create_string_utf8(env, "", 4294967296 + 1, &output));
if (SIZE_MAX > INT_MAX) {
NAPI_CALL(env, napi_create_string_utf8(env, "", ((size_t)INT_MAX) + 1, &output));
} else {
// just throw the expected error as there is nothing to test
// in this case since we can't overflow
NAPI_CALL(env, napi_throw_error(env, NULL, "Invalid argument"));
}

return output;
}
Expand Down