Skip to content

V8 icu patch 4.x #15562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 6 commits into from
Closed

V8 icu patch 4.x #15562

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4cb743d
build: run test-hash-seed at the end of test-v8
targos Jul 13, 2017
3d357eb
deps: backport e28183b5 from upstream V8
skomski Oct 5, 2015
2ac6192
deps: cherry pick d7f813b4 from V8 upstream
Sep 29, 2015
875e396
build: fix make test-v8
bnoordhuis Oct 2, 2017
82b2436
deps: backport bff3074 from V8 upstream
MylesBorins Sep 22, 2017
0cc8102
deps: backport 4e18190 from V8 upstream
jungshik Jan 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: fix make test-v8
  • Loading branch information
@bnoordhuis @MylesBorins
bnoordhuis authored and MylesBorins committed Oct 11, 2017
commit 875e396cd24cf3c6a8c3c1c945adcf4872d97a73
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ check: test
cctest: all
@out/$(BUILDTYPE)/$@

v8: export GYPFLAGS += -Dclang=0
Copy link
Copy Markdown
Contributor Author

@MylesBorins MylesBorins Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I want explicit sign off on... is it ok to use export here?

Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems fine.

v8:
tools/make-v8.sh
$(MAKE) -C deps/v8 $(V8_ARCH).$(BUILDTYPE_LOWER) $(V8_BUILD_OPTIONS)
Expand Down