Skip to content

src: change var name 'u' in url.js line 97 #15551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jason9693 wants to merge 2 commits into from
Closed

src: change var name 'u' in url.js line 97 #15551

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8feb30
change var name 'u' in line 97
jason9693 Sep 22, 2017
e1f377f
change objUrl to urlObject.
jason9693 Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
change var name 'u' in line 97 
I think using var name 'objUrl' is better then 'u'...
  • Loading branch information
@jason9693
jason9693 authored Sep 22, 2017
commit e8feb30e9ec7172462066a9b42166379f32b7522
6 changes: 3 additions & 3 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ const querystring = require('querystring');
function urlParse(url, parseQueryString, slashesDenoteHost) {
if (url instanceof Url) return url;

var u = new Url();
u.parse(url, parseQueryString, slashesDenoteHost);
return u;
var objUrl = new Url();
objUrl.parse(url, parseQueryString, slashesDenoteHost);
return objUrl;
}

Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
Expand Down