Skip to content

docs: clarify usage of the cli options: -e,-p on windows #15543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukaszewczak wants to merge 13 commits into from
Closed

docs: clarify usage of the cli options: -e,-p on windows #15543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9dd633a
test: change URIError constructor to regular expression in assert.throws
lukaszewczak Apr 25, 2017
b8393d0
test: use block-scope for tests that spans multiple statements
lukaszewczak Apr 25, 2017
4598d48
Merge branch 'master' of https://github.com/nodejs/node
lukaszewczak Sep 20, 2017
494d53f
src: prepare platform for upstream V8 changes
addaleax Sep 15, 2017
90f7d9f
fs: refactor close to use destroy
mcollina Sep 14, 2017
650f09d
http2: small fixes to compatibility layer
apapirovski Sep 19, 2017
11d72f2
doc: delete link to removed doc part
vsemozhetbyt Sep 20, 2017
60ce845
src: remove unused static variable
bnoordhuis Sep 18, 2017
51a9cfc
src: handle uv_async_init() failure
bnoordhuis Sep 18, 2017
dddd510
src: return references from getters, not copies
bnoordhuis Sep 18, 2017
8af6ce9
src: constify PerformanceEntry data members
bnoordhuis Sep 18, 2017
5d611c3
build: don't fail `make test` on source tarballs
gibfahn Sep 16, 2017
08a8074
docs: clarify usage cli options -e,-p on windows
lukaszewczak Sep 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: don't fail make test on source tarballs 
Tries to achieve the same effect as
#13658 without breaking source
tarballs. Presumably if `tools/eslint` wasn't there at all, people
would notice in the PR review!

PR-URL: #15441
Fixes: #14513
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@gibfahn @lukaszewczak
gibfahn authored and lukaszewczak committed Sep 23, 2017
commit 5d611c3e6e5fbcd51930d58a13c6cfed8162e2fc
3 changes: 1 addition & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,7 @@ cpplint:
@$(PYTHON) tools/cpplint.py $(CPPLINT_FILES)
@$(PYTHON) tools/check-imports.py

ifneq ("","$(wildcard tools/eslint/bin/eslint.js)")
ifneq ("","$(wildcard tools/eslint/)")
lint:
@EXIT_STATUS=0 ; \
$(MAKE) jslint || EXIT_STATUS=$$? ; \
Expand All @@ -943,7 +943,6 @@ lint:
@echo "Linting is not available through the source tarball."
@echo "Use the git repo instead:" \
"$ git clone https://github.com/nodejs/node.git"
exit 1

lint-ci: lint
endif
Expand Down
4 changes: 2 additions & 2 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ goto exit
if defined enable_static goto exit
if defined jslint_ci goto jslint-ci
if not defined jslint goto exit
if not exist tools\eslint\bin\eslint.js goto no-lint
if not exist tools\eslint goto no-lint
echo running jslint
%config%\node tools\eslint\bin\eslint.js --cache --rule "linebreak-style: 0" --rulesdir=tools\eslint-rules --ext=.js,.md benchmark doc lib test tools
goto exit
Expand All @@ -518,7 +518,7 @@ goto exit
:no-lint
echo Linting is not available through the source tarball.
echo Use the git repo instead: $ git clone https://github.com/nodejs/node.git
exit /b 1
goto exit

:create-msvs-files-failed
echo Failed to create vc project files.
Expand Down