Skip to content

[v6.x backport] assert.fail() accept a single argument or two arguments #15479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

[v6.x backport] assert.fail() accept a single argument or two arguments #15479

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d25b8de
assert: improve assert.fail() API
Trott Apr 9, 2017
7c10194
tools: remove assert.fail() lint rule
Trott Apr 12, 2017
e5b11f8
test: remove common.fail()
Trott Apr 9, 2017
1f4b70b
test: add cwd ENOENT known issue test
cjihrig Apr 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add cwd ENOENT known issue test 
If the current working directory is removed, Node cannot
start normally because the module system calls uv_cwd().

Refs: #12022
PR-URL: #12343
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@cjihrig @Trott
cjihrig authored and Trott committed Sep 29, 2017
commit 1f4b70b949ec1b65dcd7b6c7f8e7a204fcef0ba9
34 changes: 34 additions & 0 deletions test/known_issues/test-cwd-enoent-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict';
// Refs: https://github.com/nodejs/node/pull/12022
// If the cwd is deleted, Node cannot run files because the module system
// relies on uv_cwd(). The -e and -p flags still work though.
const common = require('../common');
const assert = require('assert');

if (common.isSunOS || common.isWindows || common.isAix) {
// The current working directory cannot be removed on these platforms.
// Change this to common.skip() when this is no longer a known issue test.
assert.fail('cannot rmdir current working directory');
return;
}

const cp = require('child_process');
const fs = require('fs');

if (process.argv[2] === 'child') {
// Do nothing.
} else {
common.refreshTmpDir();
const dir = fs.mkdtempSync(common.tmpDir + '/');
process.chdir(dir);
fs.rmdirSync(dir);
assert.throws(process.cwd,
/^Error: ENOENT: no such file or directory, uv_cwd$/);

const r = cp.spawnSync(process.execPath, [__filename, 'child']);

assert.strictEqual(r.status, 0);
assert.strictEqual(r.signal, null);
assert.strictEqual(r.stdout.toString().trim(), '');
assert.strictEqual(r.stderr.toString().trim(), '');
}