Skip to content

src: handle uv_async_init() failure #15458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 4 commits into from
Closed

src: handle uv_async_init() failure #15458

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aed64d1
src: remove unused static variable
bnoordhuis Sep 18, 2017
a628534
src: handle uv_async_init() failure
bnoordhuis Sep 18, 2017
fe2b8f3
src: return references from getters, not copies
bnoordhuis Sep 18, 2017
587b562
src: constify PerformanceEntry data members
bnoordhuis Sep 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: handle uv_async_init() failure 
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().
  • Loading branch information
@bnoordhuis
bnoordhuis committed Sep 18, 2017
commit a62853440052673e627820e0da012ba51ed7c49a
7 changes: 4 additions & 3 deletions src/node_perf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,14 @@ void MarkGarbageCollectionEnd(Isolate* isolate,
v8::GCCallbackFlags flags,
void* data) {
Environment* env = static_cast<Environment*>(data);
uv_async_t *async = new uv_async_t;
uv_async_t* async = new uv_async_t(); // coverity[leaked_storage]
if (uv_async_init(env->event_loop(), async, PerformanceGCCallback))
return delete async;
async->data =
new PerformanceEntry::Data(env, "gc", "gc",
performance_last_gc_start_mark_,
PERFORMANCE_NOW(), type);
uv_async_init(env->event_loop(), async, PerformanceGCCallback);
uv_async_send(async);
CHECK_EQ(0, uv_async_send(async));
}

inline void SetupGarbageCollectionTracking(Environment* env) {
Expand Down