Skip to content

doc: fix entryTypes type and missing link in perf_hooks.md #15406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manidlou wants to merge 2 commits into from
Closed

doc: fix entryTypes type and missing link in perf_hooks.md #15406

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
383a494
doc: fix entryTypes type and missing link in perf_hooks.md
manidlou Sep 14, 2017
504963f
doc: sort links alphabetically in perf_hooks.md
manidlou Sep 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: fix entryTypes type and missing link in perf_hooks.md
  • Loading branch information
@manidlou
manidlou committed Sep 14, 2017
commit 383a4943ea958d110efd2e2577bac5dca9ca7708
3 changes: 2 additions & 1 deletion doc/api/perf_hooks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ const obs = new PerformanceObserver((list) => {
obs.disconnect();
performance.clearFunctions();
});
obs.observe({ entryTypes: 'function' });
obs.observe({ entryTypes: ['function'] });

// A performance timeline entry will be created
wrapped();
Expand Down Expand Up @@ -656,3 +656,4 @@ require('some-module');

[`timeOrigin`]: https://w3c.github.io/hr-time/#dom-performance-timeorigin
[W3C Performance Timeline]: https://w3c.github.io/performance-timeline/
[Async Hooks]: async_hooks.html
Copy link
Copy Markdown
Member

@lpinca lpinca Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please swap this with the previous line to keep them sorted alphabetically?

Copy link
Copy Markdown
Contributor Author

@manidlou manidlou Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. Just to make sure, you mean

case 1:
a. timeOrigin
b. Async Hooks
c. W3C Performance Timeline

or case 2
a. Async Hooks
b. timeOrigin
c. W3C Performance Timeline
?

Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manidlou, case 1. Thanks.