Skip to content

n-api: add optional string length parameter #15343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sampsongao wants to merge 10 commits into from
Closed

n-api: add optional string length parameter #15343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
07e9df4
n-api: add optional string length parameters
Sep 11, 2017
53c4e81
napi: update doc for additional string length parameter
Sep 11, 2017
7a7dc8b
n-api: fix build errors
Sep 11, 2017
ef1af4a
test: update test for additional string length parameter
Sep 11, 2017
8762a3c
Handle non-zero terminated string in napi_fatal_error
Sep 15, 2017
c0b202c
Add tests for non-zero termianted string input
Sep 15, 2017
cf0f4fa
Fix errors after rebasing
Sep 15, 2017
90ef051
Fix CI run fail
Sep 15, 2017
b0175ae
Fix remaining rebasing difference
Sep 15, 2017
8e7bf47
Fix linter error
Sep 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix errors after rebasing
  • Loading branch information
Sampson Gao committed Sep 15, 2017
commit cf0f4fa0eb45bb8606f11d4603684fea504d23fd
2 changes: 1 addition & 1 deletion test/addons-napi/4_object_factory/binding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ napi_value CreateObject(napi_env env, napi_callback_info info) {

napi_value Init(napi_env env, napi_value exports) {
NAPI_CALL(env,
napi_create_function(env, "exports", CreateObject, NULL, &exports));
napi_create_function(env, "exports", -1, CreateObject, NULL, &exports));
return exports;
}

Expand Down
2 changes: 1 addition & 1 deletion test/addons-napi/5_function_factory/binding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ napi_value CreateFunction(napi_env env, napi_callback_info info) {

napi_value Init(napi_env env, napi_value exports) {
NAPI_CALL(env,
napi_create_function(env, "exports", CreateFunction, NULL, &exports));
napi_create_function(env, "exports", -1, CreateFunction, NULL, &exports));
return exports;
}

Expand Down
3 changes: 1 addition & 2 deletions test/addons-napi/6_object_wrap/myobject.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ void MyObject::Init(napi_env env, napi_value exports) {

napi_value cons;
NAPI_CALL_RETURN_VOID(env,
napi_define_class(env, "MyObject", New, nullptr, 3, properties, &cons));
napi_define_class(env, "MyObject", -1, New, nullptr, 3, properties, &cons));
napi_define_class(env, "MyObject", -1, New, nullptr, 3, properties, &cons));

NAPI_CALL_RETURN_VOID(env, napi_create_reference(env, cons, 1, &constructor));

Expand Down
2 changes: 1 addition & 1 deletion test/addons-napi/7_factory_wrap/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ napi_value Init(napi_env env, napi_value exports) {
NAPI_CALL(env, MyObject::Init(env));

NAPI_CALL(env,
napi_create_function(env, "exports", CreateObject, NULL, &exports));
napi_create_function(env, "exports", -1, CreateObject, NULL, &exports));
return exports;
}

Expand Down
2 changes: 1 addition & 1 deletion test/addons-napi/test_constructor/test_constructor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ napi_value Init(napi_env env, napi_value exports) {

napi_value cons;
NAPI_CALL_RETURN_VOID(env, napi_define_class(env, "MyObject", -1, New,
NULL, sizeof(properties)/sizeof(*properties), properties, &cons));
NULL, sizeof(properties)/sizeof(*properties), properties, &cons));

NAPI_CALL(env, napi_create_reference(env, cons, 1, &constructor_));

Expand Down
14 changes: 6 additions & 8 deletions test/addons-napi/test_constructor/test_constructor_name.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,14 @@ napi_value New(napi_env env, napi_callback_info info) {
return _this;
}

void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
napi_value Init(napi_env env, napi_value exports) {
napi_value cons;
NAPI_CALL_RETURN_VOID(env, napi_define_class(env, "MyObject_Extra", 8, New,
NULL, 0, NULL, &cons));
NAPI_CALL(env, napi_define_class(
env, "MyObject_Extra", 8, New, NULL, 0, NULL, &cons));

NAPI_CALL_RETURN_VOID(env,
napi_set_named_property(env, module, "exports", cons));

NAPI_CALL_RETURN_VOID(env,
napi_create_reference(env, cons, 1, &constructor_));
NAPI_CALL(env,
napi_create_reference(env, cons, 1, &constructor_));
return cons;
}

NAPI_MODULE(addon, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_env_sharing/compare_env.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ napi_value compare(napi_env env, napi_callback_info info) {
}

napi_value Init(napi_env env, napi_value exports) {
NAPI_CALL(env, napi_create_function(env, "exports", compare, NULL, &exports));
NAPI_CALL(env, napi_create_function(env, "exports", -1, compare, NULL, &exports));
return exports;
}

Expand Down
1 change: 1 addition & 0 deletions test/addons-napi/test_function/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ function func4(input) {
return func3(input);
}
assert.strictEqual(test_function.TestCall(func4, 1), 2);

assert.strictEqual(test_function.TestName.name, 'Name');
assert.strictEqual(test_function.TestNameShort.name, 'Name_');