Skip to content

cluster: sometimes debug-port value for child process can be broken #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Olegas wants to merge 6 commits into from
Closed

cluster: sometimes debug-port value for child process can be broken #1524

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd23c88
cluster: sometimes debug-port value for child process can be broken
Olegas Apr 25, 2015
e71cfc8
Test added
Olegas Apr 27, 2015
2a8c5e7
Fixed coding style issues
Olegas Apr 27, 2015
5ee069b
Fixed coding style issues
Olegas Apr 27, 2015
4aa3f47
Rewrite from scratch. Debug port numbers must be consecutive.
Olegas Apr 27, 2015
220e3d3
Missing semicolon
Olegas Apr 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rewrite from scratch. Debug port numbers must be consecutive.
  • Loading branch information
@Olegas
Olegas committed Apr 27, 2015
commit 4aa3f47c4fc10f736a3811e02d3564043e46ca56
18 changes: 13 additions & 5 deletions lib/cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ cluster.Worker = Worker;
cluster.isWorker = ('NODE_UNIQUE_ID' in process.env);
cluster.isMaster = (cluster.isWorker === false);

const kDebugPortStart = 1024;
const kDebugPortRange = (65536 - kDebugPortStart);
const kDebugPortMin = 1024;
const kDebugPortMax = 65535;

function Worker(options) {
if (!(this instanceof Worker))
Expand Down Expand Up @@ -281,14 +281,22 @@ function masterInit() {
cluster.emit('setup', settings);
}

var nextDebugPort = process.debugPort;

function getDebugPort() {
++nextDebugPort;
if (nextDebugPort > kDebugPortMax) {
nextDebugPort = kDebugPortMin;
}
return nextDebugPort;
}

function createWorkerProcess(id, env) {
var workerEnv = util._extend({}, process.env);
var execArgv = cluster.settings.execArgv.slice();
var debugPort = process.debugPort + id;
var debugPort = getDebugPort();
var hasDebugArg = false;

debugPort = debugPort % kDebugPortRange + kDebugPortStart;

workerEnv = util._extend(workerEnv, env);
workerEnv.NODE_UNIQUE_ID = '' + id;

Expand Down