Skip to content

n-api: Context for custom async operations #15189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasongin wants to merge 4 commits into from
Closed

n-api: Context for custom async operations #15189

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53de2e1
n-api: Context for custom async operations
jasongin Aug 26, 2017
8c09a5e
Change name parameter to napi_value
jasongin Sep 9, 2017
80371d9
Fix jslint issues in test
jasongin Sep 11, 2017
2c1e547
Replace NOT with *not* in API doc
jasongin Sep 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Replace NOT with *not* in API doc
  • Loading branch information
@jasongin
jasongin committed Sep 11, 2017
commit 2c1e547fb3ac6ffe5960601496a40377828f2fec
2 changes: 1 addition & 1 deletion doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3382,7 +3382,7 @@ add-on. This API is similar to `napi_call_function`. However, it is used to call
operation (when there is no other script on the stack). It is a fairly simple
wrapper around `node::MakeCallback`.

Note it is NOT necessary to use `napi_make_callback` from within a
Note it is *not* necessary to use `napi_make_callback` from within a
`napi_async_complete_callback`; in that situation the callback's async
context has already been set up, so a direct call to `napi_call_function`
is sufficient and appropriate. Use of the `napi_make_callback` function
Expand Down