Skip to content

test: remove arbitrary timer in test-tls-fast-writing #15138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: remove arbitrary timer in test-tls-fast-writing #15138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove arbitrary timer in test-tls-fast-writing 
test-tls-fast-writing can fail on a heavily-loaded system due to an
arbitrary 1-second timeout. Remove the arbitrary timeout.
  • Loading branch information
@Trott
Trott committed Sep 1, 2017
commit 5dcbd7f78617486659c470a2a22222e35535058a
5 changes: 0 additions & 5 deletions test/parallel/test-tls-fast-writing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ const server = tls.createServer(options, onconnection);
let gotChunk = false;
let gotDrain = false;

setTimeout(function() {
console.log('not ok - timed out');
process.exit(1);
}, common.platformTimeout(1000));

function onconnection(conn) {
conn.on('data', function(c) {
if (!gotChunk) {
Expand Down