Skip to content

lib/src: exit on gc unhandled promise #15126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 6 commits into from
Closed

lib/src: exit on gc unhandled promise #15126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
711d699
lib,src: throw on unhanded promise rejections
Fishrock123 Apr 25, 2016
af11384
lib: follow up to exit early
BridgeAR Aug 31, 2017
19c7eb3
[squash] fix linter errors
BridgeAR Sep 1, 2017
69bfdd6
[squash] fix a test and remove unnecessary fn
BridgeAR Sep 1, 2017
5d2c83e
[squash] address comments
BridgeAR Sep 26, 2017
8fd484e
[squash] fix test
BridgeAR Sep 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] fix linter errors
  • Loading branch information
@BridgeAR
BridgeAR committed Sep 26, 2017
commit 19c7eb364a3b9669a1d9e6535b30344bb8038511
12 changes: 6 additions & 6 deletions test/parallel/test-promises-gc-before-handled.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ const p = new Promise((res, rej) => {
// Manually call GC due to possible memory constraints with attempting to
// trigger it "naturally".
setTimeout(common.mustCall(() => {
gc();
gc();
gc();
global.gc();
Copy link
Copy Markdown
Member

@benjamingr benjamingr Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really flakey, why 3 times? Why these delays in the setTimeout?

Are we testing that V8 doesn't drop a live reference in GC here?

Copy link
Copy Markdown
Member

@addaleax addaleax Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been forced to check gc-based behaviour in setTimeouts in other cases in recent V8 versions. I don’t think anybody of has really gotten to the ground of it so far.

Copy link
Copy Markdown
Member

@benjamingr benjamingr Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, then a comment would be nice.

Copy link
Copy Markdown
Member Author

@BridgeAR BridgeAR Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not certain how that comment should look like. Do you have a example?

global.gc();
global.gc();
setTimeout(common.mustCall(() => {
gc();
gc();
gc();
global.gc();
global.gc();
global.gc();
setTimeout(common.mustCall(() => {
p.catch(() => {});
}, 1), 250);
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-promises-handled-reject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const p = new Promise((res, rej) => {
// trigger it "naturally".
setTimeout(common.mustCall(() => {
p.catch(() => {});
gc();
gc();
gc();
global.gc();
global.gc();
global.gc();
}, 1), 2);