Skip to content

[WIP] src: intercept property descriptors on sandbox #15114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 3 commits into from
Closed

[WIP] src: intercept property descriptors on sandbox #15114

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8497889
src: intercept property descriptors on sandbox
targos Sep 4, 2017
bd90db9
test: add known issue vm test for Reflect.ownKeys
targos Sep 4, 2017
5f2c4fa
try ToDetailString
targos Sep 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add known issue vm test for Reflect.ownKeys
  • Loading branch information
@targos
targos committed Sep 5, 2017
commit bd90db97a692e274ec5aa8390363e524774b236c
39 changes: 39 additions & 0 deletions test/known_issues/test-vm-ownkeys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
'use strict';

require('../common');
const vm = require('vm');
const assert = require('assert');

const sym1 = Symbol('1');
const sym2 = Symbol('2');
const sandbox = {
a: true,
[sym1]: true
};
Object.defineProperty(sandbox, 'b', { value: true });
Object.defineProperty(sandbox, sym2, { value: true });

const ctx = vm.createContext(sandbox);

// sanity check
assert.deepStrictEqual(Reflect.ownKeys(sandbox), ['a', 'b', sym1, sym2]);
assert.deepStrictEqual(Object.getOwnPropertyNames(sandbox), ['a', 'b']);
assert.deepStrictEqual(Object.getOwnPropertySymbols(sandbox), [sym1, sym2]);

const nativeKeys = vm.runInNewContext('Reflect.ownKeys(this);');
const ownKeys = vm.runInContext('Reflect.ownKeys(this);', ctx);
const restKeys = ownKeys.filter((key) => !nativeKeys.includes(key));
//eslint-disable-next-line no-restricted-properties
assert.deepEqual(restKeys, ['a', 'b', sym1, sym2]);

const nativeNames = vm.runInNewContext('Object.getOwnPropertyNames(this);');
const ownNames = vm.runInContext('Object.getOwnPropertyNames(this);', ctx);
const restNames = ownNames.filter((name) => !nativeNames.includes(name));
//eslint-disable-next-line no-restricted-properties
assert.deepEqual(restNames, ['a', 'b']);

const nativeSym = vm.runInNewContext('Object.getOwnPropertySymbols(this);');
const ownSym = vm.runInContext('Object.getOwnPropertySymbols(this);', ctx);
const restSym = ownSym.filter((sym) => !nativeSym.includes(sym));
//eslint-disable-next-line no-restricted-properties
assert.deepEqual(restSym, [sym1, sym2]);