Skip to content

async_hooks: docs and api ergonomics tweaks #15103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 5 commits into from
Closed

async_hooks: docs and api ergonomics tweaks #15103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73b8272
doc: some async_hooks docs improvements
jasnell Aug 30, 2017
def3c83
async_hooks: add type checking for AsyncResource type
jasnell Sep 1, 2017
f1cdae3
[Squash] Doc nits
jasnell Sep 1, 2017
b4a1075
[Squash] Update tests
jasnell Sep 6, 2017
8f032cf
[Squash] Nits
jasnell Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Squash] Update tests
  • Loading branch information
@jasnell
jasnell committed Sep 6, 2017
commit b4a1075372b480523836ff14b414fc6d7cb76193
11 changes: 5 additions & 6 deletions test/async-hooks/test-embedder.api.async-resource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ const { checkInvocations } = require('./hook-checks');
const hooks = initHooks();
hooks.enable();

assert.throws(() => {
new AsyncResource();
}, common.expectsError({
code: 'ERR_ASYNC_TYPE',
type: TypeError,
}));
common.expectsError(
() => new AsyncResource(), {
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
});
assert.throws(() => {
new AsyncResource('invalid_trigger_id', null);
}, common.expectsError({
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-async-hooks-asyncresource-constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ async_hooks.createHook({
assert.throws(() => {
return new AsyncResource();
}, common.expectsError({
code: 'ERR_ASYNC_TYPE',
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
}));

Expand Down