Skip to content

assert: fix boxed primitives in deep*Equal #15050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

assert: fix boxed primitives in deep*Equal #15050

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66432d8
assert: fix boxed primitives in deep*Equal
BridgeAR Aug 27, 2017
7dfd780
[squash] add testcase back in
BridgeAR Sep 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] add testcase back in
  • Loading branch information
@BridgeAR
BridgeAR committed Sep 11, 2017
commit 7dfd780584519369077dd32ea95f5ecef07751ce
3 changes: 1 addition & 2 deletions test/addons-napi/test_conversions/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ assert.deepStrictEqual(new Boolean(false), test.toObject(false));
assert.deepStrictEqual(new Boolean(true), test.toObject(true));
assert.deepStrictEqual(new String(''), test.toObject(''));
assert.deepStrictEqual(new Number(0), test.toObject(0));
// TODO: Add test back in as soon as NaN is properly compared
// assert.deepStrictEqual(new Number(Number.NaN), test.toObject(Number.NaN));
assert.deepStrictEqual(new Number(Number.NaN), test.toObject(Number.NaN));
assert.deepStrictEqual(new Object(testSym), test.toObject(testSym));
assert.notDeepStrictEqual(false, test.toObject(false));
assert.notDeepStrictEqual(true, test.toObject(true));
Expand Down