Skip to content

src, test: node internals' postmortem metadata #14901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 2 commits into from
Closed

src, test: node internals' postmortem metadata #14901

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
153a660
src, test: node internals' postmortem metadata
Dec 26, 2017
f798beb
[squash] workaround to fix arm64 failing test
Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] workaround to fix arm64 failing test
  • Loading branch information
Matheus Marchini committed Jan 25, 2018
commit f798beb546f3e7c9a62019f96c955c266af655d1
5 changes: 5 additions & 0 deletions test/cctest/test_node_postmortem_metadata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ TEST_F(DebugSymbolsTest, ReqWrapList) {
obj_template->GetFunction()->NewInstance(env.context()).ToLocalChecked();
TestReqWrap obj(*env, object);

// NOTE (mmarchini): Workaround to fix failing tests on ARM64 machines with
// older GCC. Should be removed once we upgrade the GCC version used on our
// ARM64 CI machinies.
for (auto it : *(*env)->req_wrap_queue()) {}

auto queue = reinterpret_cast<uintptr_t>((*env)->req_wrap_queue());
auto head = queue +
nodedbg_offset_Environment_ReqWrapQueue__head___ListNode_ReqWrapQueue;
Expand Down