Skip to content

test, win: fix IPv6 detection on Windows #14865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 2 commits into from
Closed

test, win: fix IPv6 detection on Windows #14865

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e491e7
test, win: fix IPv6 detection on Windows
bzoz Aug 16, 2017
59a2128
test: fix async-hooks tests
bzoz Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test, win: fix IPv6 detection on Windows 
Add proper IPv6 detection on loopback device on Windows.

PR-URL: #14865
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
@bzoz
bzoz committed Aug 24, 2017
commit 5e491e7766a3f0980a65329a072a0ada72767fcd
2 changes: 1 addition & 1 deletion test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ Object.defineProperty(exports, 'hasFipsCrypto', {

{
const iFaces = os.networkInterfaces();
const re = /lo/;
const re = exports.isWindows ? /Loopback Pseudo-Interface/ : /lo/;
exports.hasIPv6 = Object.keys(iFaces).some(function(name) {
return re.test(name) && iFaces[name].some(function(info) {
return info.family === 'IPv6';
Expand Down