Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
3edd272
test: add common.noop, default for common.mustCall()
jasnell Mar 24, 2017
2d96b01
tools: add rule prefering common.mustNotCall()
jasnell Mar 24, 2017
ce86b8e
test: add mustCallAtLeast
refack May 9, 2017
189dc42
test: harden test-dgram-bind-shared-ports
refack May 18, 2017
a28f7a2
dns: fix `resolve` failed starts without network
XadillaX Aug 10, 2017
cb3b866
src: supply missing comments for CLI options
sam-github Apr 5, 2017
1576c09
src: use option parser for expose_internals
sam-github Apr 5, 2017
ee98df8
test: mark test-fs-read-buffer-to-string-fail as flaky
Jeyanthinath Jul 26, 2017
3f2b8a9
test: increase coverage for path.parse
tniessen Jul 24, 2017
ba411f1
path: fix win32 volume-relative paths
TimothyGu Jul 24, 2017
d75363b
path: remove unnecessary string copies
tniessen Jul 23, 2017
cbd2c77
tools: add missing #include "unicode/putil.h"
srl295 Mar 27, 2017
0f36025
timers: do not use user object call/apply
Trott May 11, 2017
c7622e1
deps: cherry-pick f5fad6d from upstream v8
danbev May 2, 2017
2914926
src: only call FatalException if not verbose
danbev May 3, 2017
9dde328
build: reduce one level of spawning in node_gyp
refack Apr 25, 2017
4072073
test: check number of message events
Trott May 20, 2017
548aba4
test: confirm callback is invoked in fs test
Trott May 20, 2017
4442a1f
test: check noop function invocations
Trott May 21, 2017
85a8d6e
test: simplify assert usage in test-stream2-basic
Trott May 21, 2017
10ad128
test: move stream2 test from pummel to parallel
Trott May 21, 2017
8fd7fcc
build: support dtrace on ARM
bradleythughes Mar 27, 2017
6ca963a
test: replace `indexOf` with `includes`
thelostone-mc May 25, 2017
b997b8f
test: use mustNotCall() in test-stream2-objects
Trott May 26, 2017
7919eee
test: use mustCall() in test-readline-interface
Trott May 27, 2017
089bd3b
test: refactor test-net-server-bind
Trott May 29, 2017
30201e5
test: add documentation for common.mustNotCall()
Trott Jun 1, 2017
7c2befc
test: refactor test-dgram-oob-buffer
Trott Jun 3, 2017
c15393c
test: check callback not invoked on lookup error
Trott Jun 4, 2017
1a95a51
test: refactor domain tests
Trott Jun 5, 2017
8033cf3
test: refactor test-fs-read-*
Trott Jun 6, 2017
bfea6b2
src: merge `fn_name` in NODE_SET_PROTOTYPE_METHOD
XadillaX Jun 8, 2017
245f6b0
test: use mustNotCall in test-http-eof-on-connect
Trott Jun 9, 2017
6f44563
test: add mustCall() to child-process test
Trott Jun 11, 2017
2f8aa88
test: use mustNotCall() in test-fs-watch
Trott Jun 10, 2017
ac99a79
v8: fix RegExp nits in v8_prof_polyfill.js
vsemozhetbyt Jun 15, 2017
10e9f45
test: make test-http(s)-set-timeout-server alike
jklepatch Jun 12, 2017
7aee51f
test: refactor test-http-set-timeout-server
Trott Jun 19, 2017
2ef11d5
test: remove needless RegExp flags
vsemozhetbyt Jun 15, 2017
29141c0
test: use string instead of RegExp in split()
vsemozhetbyt Jun 16, 2017
366d1a8
doc: add missing zlib link to stream API docs
Rob--W Jun 21, 2017
b5d763f
test: remove unnecessary Buffer import
swinston1000 Jun 21, 2017
dda959d
test: remove require('buffer') on 6 fs test files
sallen450 Jun 21, 2017
611ae1e
test: remove require('buffer') from 4 buffer tests
OriLev Jun 21, 2017
bfd296b
test: remove `require('buffer')` from 4 test files
leizongmin Jun 21, 2017
036a97c
test: remove unnecessary require('buffer').Buffer
lenakaplan Jun 21, 2017
47dd8f0
test: remove `require('buffer')` from 4 test files
XadillaX Jun 21, 2017
b801c75
build: clean up config_fips.gypi
danbev Jun 21, 2017
cb8d837
test: make http(s)-set-timeout-server more similar
jklepatch Jun 20, 2017
b9837ff
test: refactor test-tls-env-extra-ca
Trott Jun 23, 2017
e5f8141
test: refactor test-tls-invoked-queued
Trott Jun 23, 2017
3a45bde
test: skip fips tests using OpenSSL config file
danbev Jun 18, 2017
da8851c
doc: fixed formatting issue in cli docs
Jun 20, 2017
8fcae92
test: remove unneeded HandleScope usage
ezequielgarcia Jun 19, 2017
9575c97
doc: fix mistake in path.relative
tniessen Jun 25, 2017
1ae897d
doc: add gireeshpunathil to collaborators
gireeshpunathil Jun 28, 2017
92c46ff
doc: add @nodejs/documentation to CC table
vsemozhetbyt Jun 27, 2017
4542915
tools: remove comment in eslint rule
danbev Jun 27, 2017
df50e01
test: refactor test-cluster-basic
Trott Jun 25, 2017
de8c16e
doc: note that fs.futimes only works on AIX >7.1
gibfahn Jun 13, 2017
8de2eca
src: add missing new line to printed message
TimothyGu Jun 26, 2017
3cae68a
test: refactor test-child-process-send-type-error
Trott Jun 25, 2017
401f3ce
src: move crypto_bio/clienthello to crypto ns
danbev Jun 28, 2017
d133e33
lib: fix typos
BridgeAR Jun 17, 2017
5336457
test: refactor test-fs-watchfile
Trott Jun 16, 2017
5160d3d
child_process: fix handleless NODE_HANDLE handling
santigimeno May 25, 2017
259e8e4
test: remove undef NDEBUG from at-exit addons test
danbev Jun 30, 2017
d6841b3
test: replace indexOf with includes and startsWith
Jun 21, 2017
c343d91
doc: fix example in child_process.md
rus0000 Jun 16, 2017
53b707d
test: refactor test-http-invalidheaderfield
Trott Jun 30, 2017
17f3dc1
doc: add CTC members to Collaborators list
Trott May 29, 2017
c5a427f
test: refactor test-http(s)-set-timeout-server
aqrln Jun 26, 2017
03a5c5a
test,fs: delay unlink in test-regress-GH-4027.js
jaimecbernardo Jun 30, 2017
78dc4f1
test: fix require nits in some test-tls-* tests
vsemozhetbyt Jun 30, 2017
95ca4ac
doc, util, console: clarify ambiguous docs
nattelog Jul 1, 2017
0dbe822
tools: use no-use-before-define ESLint rule
vsemozhetbyt Jul 1, 2017
ca6184c
src: remove GTEST_DONT_DEFINE_ASSERT_EQ in util.h
danbev Apr 25, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib: fix typos
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
BridgeAR authored and MylesBorins committed Aug 14, 2017
commit d133e33dbfb994ed9de3778866f7960aa7e729b0
6 changes: 3 additions & 3 deletions lib/_tls_wrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ TLSSocket.prototype._init = function(socket, wrap) {

// lib/net.js expect this value to be non-zero if write hasn't been flushed
// immediately
// TODO(indutny): rewise this solution, it might be 1 before handshake and
// TODO(indutny): revise this solution, it might be 1 before handshake and
// represent real writeQueueSize during regular writes.
ssl.writeQueueSize = 1;

Expand Down Expand Up @@ -705,7 +705,7 @@ TLSSocket.prototype.getProtocol = function() {
// outcomes:
//
// A) verifyError returns null meaning the client's certificate is signed
// by one of the server's CAs. The server know's the client idenity now
// by one of the server's CAs. The server now knows the client's identity
// and the client is authorized.
//
// B) For some reason the client's certificate is not acceptable -
Expand Down Expand Up @@ -984,7 +984,7 @@ function normalizeConnectArgs(listArgs) {
var cb = args[1];

// If args[0] was options, then normalize dealt with it.
// If args[0] is port, or args[0], args[1] is host,port, we need to
// If args[0] is port, or args[0], args[1] is host, port, we need to
// find the options and merge them in, normalize's options has only
// the host/port/path args that it knows about, not the tls options.
// This means that options.host overrides a host arg.
Expand Down
4 changes: 2 additions & 2 deletions lib/buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function alignPool() {
}

/**
* The Buffer() construtor is "soft deprecated" ... that is, it is deprecated
* The Buffer() constructor is "soft deprecated" ... that is, it is deprecated
* in the documentation and should not be used moving forward. Rather,
* developers should use one of the three new factory APIs: Buffer.from(),
* Buffer.allocUnsafe() or Buffer.alloc() based on their specific needs. There
Expand Down Expand Up @@ -124,7 +124,7 @@ Buffer.alloc = function(size, fill, encoding) {
// Since we are filling anyway, don't zero fill initially.
// Only pay attention to encoding if it's a string. This
// prevents accidentally sending in a number that would
// be interpretted as a start offset.
// be interpreted as a start offset.
if (typeof encoding !== 'string')
encoding = undefined;
return createUnsafeBuffer(size).fill(fill, encoding);
Expand Down
4 changes: 2 additions & 2 deletions lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -1651,7 +1651,7 @@ fs.realpathSync = function realpathSync(p, options) {
}
}

// walk down the path, swapping out linked pathparts for their real
// walk down the path, swapping out linked path parts for their real
// values
// NB: p.length changes.
while (pos < p.length) {
Expand Down Expand Up @@ -1765,7 +1765,7 @@ fs.realpath = function realpath(p, options, callback) {
}
}

// walk down the path, swapping out linked pathparts for their real
// walk down the path, swapping out linked path parts for their real
// values
function LOOP() {
// stop if scanned past end of path
Expand Down
6 changes: 3 additions & 3 deletions lib/internal/socket_list.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {SocketListSend, SocketListReceive};
const EventEmitter = require('events');
const util = require('util');

// This object keep track of the socket there are sended
// This object keeps track of the sockets that are sent
function SocketListSend(slave, key) {
EventEmitter.call(this);

Expand Down Expand Up @@ -54,7 +54,7 @@ SocketListSend.prototype.getConnections = function getConnections(callback) {
});
};

// This object keep track of the socket there are received
// This object keeps track of the sockets there are received
function SocketListReceive(slave, key) {
EventEmitter.call(this);

Expand Down Expand Up @@ -95,7 +95,7 @@ util.inherits(SocketListReceive, EventEmitter);
SocketListReceive.prototype.add = function(obj) {
this.connections++;

// Notify previous owner of socket about its state change
// Notify the previous owner of the socket about its state change
obj.socket.once('close', () => {
this.connections--;

Expand Down
4 changes: 2 additions & 2 deletions lib/repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function REPLServer(prompt,

if (breakEvalOnSigint && eval_) {
// Allowing this would not reflect user expectations.
// breakEvalOnSigint affects only the behaviour of the default eval().
// breakEvalOnSigint affects only the behavior of the default eval().
throw new Error('Cannot specify both breakEvalOnSigint and eval for REPL');
}

Expand Down Expand Up @@ -817,7 +817,7 @@ REPLServer.prototype.complete = function() {
function complete(line, callback) {
// There may be local variables to evaluate, try a nested REPL
if (this.bufferedCommand !== undefined && this.bufferedCommand.length) {
// Get a new array of inputed lines
// Get a new array of inputted lines
var tmp = this.lines.slice();
// Kill off all function declarations to push all local variables into
// global scope
Expand Down
4 changes: 2 additions & 2 deletions lib/timers.js
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ exports.setTimeout = function(callback, after, arg1, arg2, arg3) {
function createSingleTimeout(callback, after, args) {
after *= 1; // coalesce to number or NaN
if (!(after >= 1 && after <= TIMEOUT_MAX))
after = 1; // schedule on next tick, follows browser behaviour
after = 1; // schedule on next tick, follows browser behavior

var timer = new Timeout(after, callback, args);
if (process.domain)
Expand Down Expand Up @@ -454,7 +454,7 @@ exports.setInterval = function(callback, repeat, arg1, arg2, arg3) {
function createRepeatTimeout(callback, repeat, args) {
repeat *= 1; // coalesce to number or NaN
if (!(repeat >= 1 && repeat <= TIMEOUT_MAX))
repeat = 1; // schedule on next tick, follows browser behaviour
repeat = 1; // schedule on next tick, follows browser behavior

var timer = new Timeout(repeat, callback, args);
timer._repeat = repeat;
Expand Down
2 changes: 1 addition & 1 deletion lib/tls.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const Buffer = require('buffer').Buffer;

// Allow {CLIENT_RENEG_LIMIT} client-initiated session renegotiations
// every {CLIENT_RENEG_WINDOW} seconds. An error event is emitted if more
// renegotations are seen. The settings are applied to all remote client
// renegotiations are seen. The settings are applied to all remote client
// connections.
exports.CLIENT_RENEG_LIMIT = 3;
exports.CLIENT_RENEG_WINDOW = 600;
Expand Down
2 changes: 1 addition & 1 deletion lib/tty.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function WriteStream(fd) {

// Prevents interleaved or dropped stdout/stderr output for terminals.
// As noted in the following reference, local TTYs tend to be quite fast and
// this behaviour has become expected due historical functionality on OS X,
// this behavior has become expected due historical functionality on OS X,
// even though it was originally intended to change in v1.0.2 (Libuv 1.2.1).
// Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
this._handle.setBlocking(process.env.NODE_TTY_UNSAFE_ASYNC !== '1');
Expand Down
2 changes: 1 addition & 1 deletion lib/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ function autoEscapeStr(rest) {
var lastEscapedPos = 0;
for (var i = 0; i < rest.length; ++i) {
// Manual switching is faster than using a Map/Object.
// `escaped` contains substring up to the last escaped cahracter.
// `escaped` contains substring up to the last escaped character.
switch (rest.charCodeAt(i)) {
case 9: // '\t'
// Concat if there are ordinary characters in the middle.
Expand Down