Skip to content

test: make timers-blocking-callback more reliable #14831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 5 commits into from
Closed

test: make timers-blocking-callback more reliable #14831

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83208ab
test: make timers-blocking-callback more reliable
Trott Aug 14, 2017
c208131
squash: message nit
Trott Aug 18, 2017
fce2712
squash: update comment
Trott Aug 18, 2017
ec83819
squash: > to >=
Trott Aug 18, 2017
0f352fd
squash: do not timer-bomb ourselves
Trott Aug 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: > to >=
  • Loading branch information
@Trott
Trott committed Aug 18, 2017
commit ec83819c6ef1e218e27e9ffdfbee5cc3d7567651
2 changes: 1 addition & 1 deletion test/sequential/test-timers-blocking-callback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function blockingCallback(retry, callback) {
// But they are guaranteed to be at least 100ms late given the bug in
// https://github.com/nodejs/node-v0.x-archive/issues/15447 and
// https://github.com/nodejs/node-v0.x-archive/issues/9333.
if (latestDelay > TIMEOUT * 2) {
if (latestDelay >= TIMEOUT * 2) {
if (retries > 0) {
retries--;
return retry(callback);
Expand Down