[fixup] lib/net.js update createHandle() err

- Create a new error 'ERR_INVALID_FD_TYPE' in lib/internal/errors.js, following the corresponding discussion at Ref: #14782. This error should be thrown when a file descriptor type is not valid. - add test for the new err in test-internal-errors.js - update the error doc in errors.md - use the new err in createHandle() in lib/net.js - Add brackets {} in arrow function in test-net-localerror.js to match the typical source code's format.
nodejs · pmatzavin · Aug 11, 2017 · Aug 20, 2017 · Aug 20, 2017 · Aug 21, 2017
commit 056dfcc0ed72f34e70b1165c452e4c92885cea16
diff --git a/doc/api/errors.md b/doc/api/errors.md
@@ -918,6 +918,11 @@ Used when `hostname` can not be parsed from a provided URL.
 
 Used when a file descriptor ('fd') is not valid (e.g. it has a negative value).
 
+<a id="ERR_INVALID_FD_TYPE"></a>
+### ERR_INVALID_FD_TYPE
+
+Used when a file descriptor ('fd') type is not valid.
+
 <a id="ERR_INVALID_FILE_URL_HOST"></a>
 ### ERR_INVALID_FILE_URL_HOST
 

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -219,6 +219,7 @@ E('ERR_INVALID_CURSOR_POS',
   'Cannot set cursor row without setting its column');
 E('ERR_INVALID_DOMAIN_NAME', 'Unable to determine the domain name');
 E('ERR_INVALID_FD', '"fd" must be a positive integer: %s');
+E('ERR_INVALID_FD_TYPE', 'Unsupported fd type: %s');
 E('ERR_INVALID_FILE_URL_HOST',
   'File URL host must be "localhost" or empty on %s');
 E('ERR_INVALID_FILE_URL_PATH', 'File URL path %s');

diff --git a/lib/net.js b/lib/net.js
@@ -64,7 +64,7 @@ function createHandle(fd) {
   const type = TTYWrap.guessHandleType(fd);
   if (type === 'PIPE') return new Pipe();
   if (type === 'TCP') return new TCP();
-  throw new errors.Error('ERR_INVALID_HANDLE_TYPE');
+  throw new errors.Error('ERR_INVALID_FD_TYPE', type);
 }
 
 

diff --git a/test/parallel/test-internal-errors.js b/test/parallel/test-internal-errors.js
@@ -207,6 +207,10 @@ assert.strictEqual(
   errors.message('ERR_INVALID_ARG_TYPE', [['a', 'b', 'c'], 'not d']),
   'The "a", "b", "c" arguments must not be of type d');
 
+// Test ERR_INVALID_FD_TYPE
+assert.strictEqual(errors.message('ERR_INVALID_FD_TYPE', ['a']),
+                   'Unsupported fd type: a');
+
 // Test ERR_INVALID_URL_SCHEME
 assert.strictEqual(errors.message('ERR_INVALID_URL_SCHEME', ['file']),
                    'The URL must be of scheme file');

diff --git a/test/parallel/test-net-localerror.js b/test/parallel/test-net-localerror.js
@@ -23,10 +23,12 @@
 const common = require('../common');
 const net = require('net');
 
-const connect = (opts, code, type) => common.expectsError(
-  () => net.connect(opts),
-  { code, type }
-);
+const connect = (opts, code, type) => {
+  common.expectsError(
+    () => net.connect(opts),
+    { code, type }
+  );
+};
 
 connect({
   host: 'localhost',