Skip to content

test: add case to test-http-methods.js #14773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oantoro wants to merge 3 commits into from
Closed

test: add case to test-http-methods.js #14773

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30ea061
test: add case to test-http-methods.js
Aug 11, 2017
cde2aa8
test: cover all http methods in HTTP parser
Aug 11, 2017
aaf36d2
test: remove redundant test case in test-http-methods.js
Aug 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add case to test-http-methods.js 
Add more case to check existence of DELETE and PUT methods.

Refs: #14544
  • Loading branch information
Oky Antoro committed Aug 11, 2017
commit 30ea061afb54717ba737e5f65ac56b96630310bd
2 changes: 2 additions & 0 deletions test/parallel/test-http-methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ const util = require('util');

assert(Array.isArray(http.METHODS));
assert(http.METHODS.length > 0);
Copy link
Copy Markdown
Contributor

@aqrln aqrln Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is now redundant, you may safely remove it.

assert(http.METHODS.includes('DELETE'));
assert(http.METHODS.includes('GET'));
assert(http.METHODS.includes('HEAD'));
assert(http.METHODS.includes('POST'));
assert(http.METHODS.includes('PUT'));
assert.deepStrictEqual(util._extend([], http.METHODS), http.METHODS.sort());