Skip to content

http2: improve perf of passing headers to C++ #14723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 7 commits into from
Closed

http2: improve perf of passing headers to C++ #14723

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6d3a00
http2: improve perf of passing headers to C++
addaleax Aug 9, 2017
327da38
[squash] use WriteOneByte
addaleax Aug 10, 2017
d02a8a7
[squash] bump buffer size to 3000 bytes
addaleax Aug 10, 2017
a9d9f6d
[squash] address alignment concern
addaleax Aug 10, 2017
eea3825
[squash] use arrays in test again
addaleax Aug 10, 2017
b7080cf
[squash] whitespace nit
addaleax Aug 10, 2017
95964a1
[squash] fix linting (oops)
addaleax Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] use WriteOneByte
  • Loading branch information
@addaleax
addaleax committed Aug 10, 2017
commit 327da3894ea61caf8cd48be20b093b4bfe43c636
10 changes: 6 additions & 4 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,7 @@ Headers::Headers(Isolate* isolate,
CHECK(header_string->IsString());
CHECK(header_count->IsUint32());
count_ = header_count.As<Uint32>()->Value();
size_t header_string_len = header_string.As<String>()->Length();
int header_string_len = header_string.As<String>()->Length();

if (count_ == 0) {
CHECK_EQ(header_string_len, 0);
Expand All @@ -1100,9 +1100,11 @@ Headers::Headers(Isolate* isolate,
char* header_contents = *buf_ + (count_ * sizeof(nghttp2_nv));
nghttp2_nv* const nva = reinterpret_cast<nghttp2_nv*>(*buf_);

CHECK_EQ(StringBytes::Write(isolate,
header_contents, header_string_len,
header_string, ASCII), header_string_len);
CHECK_EQ(header_string.As<String>()
->WriteOneByte(reinterpret_cast<uint8_t*>(header_contents),
0, header_string_len,
String::NO_NULL_TERMINATION),
header_string_len);

size_t n = 0;
char* p;
Expand Down