Skip to content

lib: consistent this in callbacks #14645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 5 commits into from
Closed

lib: consistent this in callbacks #14645

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b3166e3
test: refactor test-fs-stat
Trott Aug 6, 2017
9d6365a
fs: invoke callbacks with undefined context
Trott Aug 6, 2017
23918c4
test: check `this` value for `nextTick()`
Trott Aug 6, 2017
aa07e87
process: make `this` value consistent
Trott Aug 6, 2017
64e1f00
benchmark: cover more nextTick() code
Trott Aug 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: check this value for nextTick() 
Depending on how many arguments are provided, `nextTick()` may run its
callback with `this` set to `null` or not. Add assertions for
both cases.
  • Loading branch information
@Trott
Trott committed Aug 9, 2017
commit 23918c4cd4e5a5ff0e1f9bf0a46465a33a8936d9
16 changes: 16 additions & 0 deletions test/parallel/test-next-tick.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

'use strict';
const common = require('../common');

const assert = require('assert');

process.nextTick(common.mustCall(function() {
Expand All @@ -40,8 +41,23 @@ const obj = {};
process.nextTick(function(a, b) {
assert.strictEqual(a, 42);
assert.strictEqual(b, obj);
assert.strictEqual(this, undefined);
}, 42, obj);

process.nextTick((a, b) => {
assert.strictEqual(a, 42);
assert.strictEqual(b, obj);
assert.deepStrictEqual(this, {});
}, 42, obj);

process.nextTick(function() {
assert.strictEqual(this, null);
}, 1, 2, 3, 4);

process.nextTick(() => {
assert.deepStrictEqual(this, {});
}, 1, 2, 3, 4);

process.on('exit', function() {
process.nextTick(common.mustNotCall());
});