Skip to content

build: fix build break when omitting icu #14533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MSLaguana wants to merge 1 commit into from
Closed

build: fix build break when omitting icu #14533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: fix build break when omitting icu 
When building without ICU (`vcbuild.bat intl-none`) the unicode/ucnv.h
header is not available, which caused compilation errors prior to this
change.
  • Loading branch information
@MSLaguana
MSLaguana committed Jul 28, 2017
commit 07f371eea27e6d70ea1d1f99df3091b888a8cfe4
1 change: 0 additions & 1 deletion src/node_i18n.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "node.h"
#include <unicode/ucnv.h>
#include <string>

#if defined(NODE_HAVE_I18N_SUPPORT)
Expand Down