Skip to content

test: fix error when foo in path to git clone #14506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SwimmingSage wants to merge 5 commits into from
Closed

test: fix error when foo in path to git clone #14506

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0bd6ac8
"test: fix error when foo in path to git clone
SwimmingSage Jul 26, 2017
8d7445c
"test assert: edit to regex error when foo in path to git clone
SwimmingSage Jul 26, 2017
8bcca8f
"test assert: edit to test case when foo is in path to git clone
SwimmingSage Jul 26, 2017
ed89e4b
"test assert: update to prior commit, more specific regex
SwimmingSage Jul 26, 2017
441a7b4
"test assert: update to previous commit of regex
SwimmingSage Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-assert-fail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ common.expectsError(() => {
// The stackFrameFunction should exclude the foo frame
assert.throws(
function foo() { assert.fail('first', 'second', 'message', '!==', foo); },
(err) => !/foo/m.test(err.stack)
(err) => !/\sat\sfoo/.test(err.stack)
Copy link
Copy Markdown
Contributor

@vsemozhetbyt vsemozhetbyt Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe /\sat\sfoo\b/ to be extra careful?

Copy link
Copy Markdown
Contributor Author

@SwimmingSage SwimmingSage Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can do that, thank you for the feedback again

);