Skip to content

lib: repl add .load-editor feature #14503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robbinhan wants to merge 4 commits into from
Closed

lib: repl add .load-editor feature #14503

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd1aa37
lib: repl for #14022
robbinhan Jul 26, 2017
141b682
lib: repl for #14022
robbinhan Aug 9, 2017
22b2c38
lib: repl for #14022
robbinhan Aug 9, 2017
10b36b3
lib: repl for #14022
robbinhan Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: repl for #14022
  • Loading branch information
@robbinhan
robbinhan committed Aug 15, 2017
commit 10b36b37d2db7a18fa7c854a3a0bcd0675eaf5bd
1 change: 1 addition & 0 deletions doc/api/repl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ The following special commands are supported by all REPL instances:
`> .load ./file/to/load.js`
* `.editor` - Enter editor mode (`<ctrl>-D` to finish, `<ctrl>-C` to cancel)
* `.load-editor` - Load a file and enter editor mode (`<ctrl>-D` to finish, `<ctrl>-C` to cancel)
Copy link
Copy Markdown
Member

@jasnell jasnell Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to have an example

Copy link
Copy Markdown
Author

@robbinhan robbinhan Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean add an example in doc?

Copy link
Copy Markdown
Member

@jasnell jasnell Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. For instance, I presume there's a way of providing the file name to load but that's not captured here

Copy link
Copy Markdown
Contributor

@Fishrock123 Fishrock123 Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just how .load does it should be fine, the second line.

Copy link
Copy Markdown
Author

@robbinhan robbinhan Aug 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have updated doc file

`> .load-editor ./file/to/load.js`

<!-- eslint-skip -->
```js
Expand Down