Skip to content

repl: do not consider ... as a REPL command #14467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivanth wants to merge 5 commits into from
Closed

repl: do not consider ... as a REPL command #14467

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5b6ec8
repl:Do not consider `...` as a REPL command
shivanth Jul 23, 2017
e2a61f6
use !== instead of !=
shivanth Jul 25, 2017
067ed99
Add test for REPL
shivanth Jul 26, 2017
cfce5a2
Fix the test, add the .break command after the test
shivanth Jul 26, 2017
08327ff
Make a more concrete test case
shivanth Jul 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make a more concrete test case
  • Loading branch information
@shivanth
shivanth committed Jul 27, 2017
commit 08327ff1b175b0d9459ac99e92fddfc9598f3457
8 changes: 6 additions & 2 deletions test/parallel/test-repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,12 @@ function error_test() {
{ client: client_unix, send: ' \t \n',
expect: prompt_unix },
//Do not parse `...[]` as a REPL keyword
Copy link
Copy Markdown
Contributor

@Fishrock123 Fishrock123 Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linter might fail due to no space between the comment start?

Copy link
Copy Markdown
Contributor

@silverwind silverwind Jul 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes as we do not use the spaced-comment rule. I fixed it anyways.

{ client: client_unix, send: '...[]\n.break',
expect: `${prompt_multiline}${prompt_unix}` }
{ client: client_unix, send: '...[]\n',
expect: `${prompt_multiline}` },
//bring back the repl to prompt
{ client: client_unix, send: '.break',
expect: `${prompt_unix}` }

]);
}

Expand Down