Skip to content

test: improve zlib tests #14455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 10 commits into from
Closed

test: improve zlib tests #14455

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
14dcd38
test: improve test-zlib
jasnell Jul 24, 2017
8a8f329
test: improve test-zlib-write-after-flush
jasnell Jul 24, 2017
5683446
test: improve test-zlib-sync-no-event
jasnell Jul 24, 2017
509498c
test: improve test-zlib-random-byte-pipes
jasnell Jul 24, 2017
c46527a
test: improve test-zlib-invalid-input
jasnell Jul 24, 2017
13e3aa2
test: improve test-zlib-from-string
jasnell Jul 24, 2017
5830895
test: improve test-zlib-from-gzip
jasnell Jul 24, 2017
df0be87
test: improve test-zlib-from-gzip-with-trailing-garbage
jasnell Jul 24, 2017
a905f3b
[Squash] Fix nits
jasnell Jul 24, 2017
a03fa00
[Squash] Fix nits
jasnell Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: improve test-zlib-invalid-input
  • Loading branch information
@jasnell
jasnell committed Aug 3, 2017
commit c46527a11ce2fb590aabe29636695ada17465c5d
48 changes: 21 additions & 27 deletions test/parallel/test-zlib-invalid-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,45 +22,39 @@
'use strict';
// test uncompressing invalid input

require('../common');
const common = require('../common');
const assert = require('assert');
const zlib = require('zlib');

const nonStringInputs = [1, true, { a: 1 }, ['a']];
const nonStringInputs = [
1,
true,
{ a: 1 },
['a']
];

console.error('Doing the non-strings');
nonStringInputs.forEach(function(input) {
// zlib.Unzip classes need to get valid data, or else they'll throw.
const unzips = [
zlib.Unzip(),
zlib.Gunzip(),
zlib.Inflate(),
zlib.InflateRaw()
];

nonStringInputs.forEach(common.mustCall((input) => {
// zlib.gunzip should not throw an error when called with bad input.
assert.doesNotThrow(function() {
zlib.gunzip(input, function(err, buffer) {
// zlib.gunzip should pass the error to the callback.
assert.ok(err);
});
});
});

console.error('Doing the unzips');
// zlib.Unzip classes need to get valid data, or else they'll throw.
const unzips = [ zlib.Unzip(),
zlib.Gunzip(),
zlib.Inflate(),
zlib.InflateRaw() ];
const hadError = [];
unzips.forEach(function(uz, i) {
console.error(`Error for ${uz.constructor.name}`);
uz.on('error', function(er) {
console.error('Error event', er);
hadError[i] = true;
});
}, nonStringInputs.length));

uz.on('end', function(er) {
throw new Error(`end event should not be emitted ${uz.constructor.name}`);
});
unzips.forEach(common.mustCall((uz, i) => {
uz.on('error', common.mustCall());
uz.on('end', common.mustNotCall);

// this will trigger error event
uz.write('this is not valid compressed data.');
});

process.on('exit', function() {
assert.deepStrictEqual(hadError, [true, true, true, true], 'expect 4 errors');
});
}, unzips.length));