Skip to content

(v6.x backport) http: describe parse err in debug output #14416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 14 commits into from
Closed

(v6.x backport) http: describe parse err in debug output #14416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2fb1381
doc: document and test that methods return this
sam-github Jun 7, 2017
dce4a75
test: mark test-fs-readdir-ucs2 flaky
joaocgreis Jun 29, 2017
448c8d4
test: mark test-npm-install flaky on arm
refack Jul 2, 2017
3b2c791
build: run test-hash-seed at the end of test-v8
targos Jul 13, 2017
ddc8050
cluster, dns, repl, tls, util: fix RegExp nits
vsemozhetbyt Jun 7, 2017
0b17a45
net: support passing undefined to listen()
sam-github Jul 14, 2017
424fad5
doc: prepare js code for eslint-plugin-markdown
vsemozhetbyt Apr 21, 2017
19ff807
doc: conform to rules for eslint-plugin-markdown
vsemozhetbyt Apr 21, 2017
ce4718f
build, doc, tools: add eslint-plugin-markdown
vsemozhetbyt Jul 4, 2017
05b95fa
tools: remove no-useless-regex-char-class-escape
Trott Jan 1, 2017
c52f60f
tools: fix indentation in required-modules.js
Trott Jun 18, 2017
4d91ff4
tools: apply stricter indentation rules to tools
Trott Jun 18, 2017
ecc50e9
tools: fix error in custom ESLint rule
Trott Jun 19, 2017
cf8045a
http: describe parse err in debug output
sam-github May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
http: describe parse err in debug output 
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information
@sam-github
sam-github committed Jul 21, 2017
commit cf8045a5ec18957fdb62dd9aa08c25be5f2794fd
2 changes: 1 addition & 1 deletion lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ function socketOnData(d) {

var ret = parser.execute(d);
if (ret instanceof Error) {
debug('parse error');
debug('parse error', ret);
freeParser(parser, req, socket);
socket.destroy();
req.emit('error', ret);
Expand Down
2 changes: 1 addition & 1 deletion lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ function connectionListener(socket) {

function onParserExecuteCommon(ret, d) {
if (ret instanceof Error) {
debug('parse error');
debug('parse error', ret);
socketOnError.call(socket, ret);
} else if (parser.incoming && parser.incoming.upgrade) {
// Upgrade or CONNECT
Expand Down