Skip to content

test: fix flaky http(s)-set-timeout-server tests #14380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 8 commits into from
Closed

test: fix flaky http(s)-set-timeout-server tests #14380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
845e15d
test: fix flaky http(s)-set-server-timeout tests
Trott Jul 20, 2017
18086fd
squash: remove functions that might not be invoked
Trott Jul 21, 2017
eef98b1
squash: move timeout handler setting to end callback
Trott Jul 21, 2017
7f7712e
squash: remove erroneous check that timeout is not emitted
Trott Jul 22, 2017
5394374
squash: allow ECONNRESET in non-deterministic test
Trott Jul 22, 2017
b02787d
squash: whoops, missed a spot
Trott Jul 22, 2017
e3dc68f
squash: last of the flakiness, I think
Trott Jul 22, 2017
340c06a
squash: comments per refack nits
Trott Jul 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: remove erroneous check that timeout is not emitted
  • Loading branch information
@Trott
Trott committed Jul 24, 2017
commit 7f7712e87a66f0aed27c72fceda3d2b904e6b060
2 changes: 1 addition & 1 deletion test/parallel/test-http-set-timeout-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ test(function fastTimeout(cb) {

const server = http.createServer(common.mustCall((req, res) => {
req.on('timeout', common.mustNotCall());
res.end(() => { res.on('timeout', common.mustNotCall()); });
res.end();
Copy link
Copy Markdown
Contributor

@refack refack Jul 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to res.on('timeout', common.mustNotCall());?

Copy link
Copy Markdown
Member Author

@Trott Trott Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be emitted so common.mustNotCall() was wrong. See #14380 (comment).

connectionHandlerInvoked = true;
invokeCallbackIfDone();
}));
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-set-timeout-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ test(function fastTimeout(cb) {
const server = https.createServer(serverOptions, common.mustCall(
(req, res) => {
req.on('timeout', common.mustNotCall());
res.end(() => { res.on('timeout', common.mustNotCall()); });
res.end();
connectionHandlerInvoked = true;
invokeCallbackIfDone();
}
Expand Down