Skip to content

test: replace with template literals #14293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Suixinlei wants to merge 3 commits into from
Closed

test: replace with template literals #14293

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d5332f
test: replace with template literals
Jul 16, 2017
19e3bb1
test: replace with template literals
Jul 16, 2017
5d9d6fc
test: replace with template literals
Jul 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replace with template literals
  • Loading branch information
笑斌 committed Jul 16, 2017
commit 6d5332fdf57c08a6b1f89da1eb3025c7032ca8d4
2 changes: 1 addition & 1 deletion test/inspector/inspector-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ Harness.prototype.addStderrFilter = function(regexp, callback) {

Harness.prototype.assertStillAlive = function() {
assert.strictEqual(this.running_, true,
'Child died: ' + JSON.stringify(this.result_));
`Child died: ${JSON.stringify(this.result_)}`);
Copy link
Copy Markdown
Member

@benjamingr benjamingr Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually the last one to worry about that sort of stuff - but is it possible this terminology is offensive? If we swapped out other trigger references I think it would be nice to have a code base without dead children.

It's entirely appropriate in terms of my culture and language background - but I want to check how others feel about it. If someone feels strongly - will open an issue.

Copy link
Copy Markdown
Contributor

@vsemozhetbyt vsemozhetbyt Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a not native speaker, I think this can be disturbing.

Copy link
Copy Markdown
Member

@gireeshpunathil gireeshpunathil Jul 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lexically this has reasonable affinity with #13684, so makes sense to change the wordings, though through another PR - as the objective of this one is to introduce template strings and is met.

Copy link
Copy Markdown
Member

@jasnell jasnell Jul 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make it Child exited ${JSON.stringify(this.result_)}

};

Harness.prototype.run_ = function() {
Expand Down