Skip to content

test: refactor test-httpparser.response.js #14290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erdun wants to merge 1 commit into from
Closed

test: refactor test-httpparser.response.js #14290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-httpparser.response.js 
* replace CRLF constant with '\r\n' literal
* fix typo in HTTP header name
  • Loading branch information
@erdun @Trott
erdun authored and Trott committed Jul 26, 2017
commit 65eac6b172fcf4a9f0a082f08cce170d6292c4ba
9 changes: 4 additions & 5 deletions test/async-hooks/test-httpparser.response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const { checkInvocations } = require('./hook-checks');
const binding = process.binding('http_parser');
const HTTPParser = binding.HTTPParser;

const CRLF = '\r\n';
const RESPONSE = HTTPParser.RESPONSE;
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
const kOnBody = HTTPParser.kOnBody | 0;
Expand All @@ -19,10 +18,10 @@ const hooks = initHooks();
hooks.enable();

const request = Buffer.from(
'HTTP/1.1 200 OK' + CRLF +
'Content-types: text/plain' + CRLF +
'Content-Length: 4' + CRLF +
CRLF +
'HTTP/1.1 200 OK\r\n' +
'Content-Type: text/plain\r\n' +
'Content-Length: 4\r\n' +
'\r\n' +
'pong'
);

Expand Down