Skip to content

[js-confcn]replace string concatenation with template literals #14269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4garfield wants to merge 2 commits into from
Closed

[js-confcn]replace string concatenation with template literals #14269

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f2b125
replace string concatenation with template literals
4garfield Jul 16, 2017
785b0d9
test: replace string concatenation
4garfield Jul 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: replace string concatenation 
replace string-concation in test/async-hooks/test-signalwrap.js with template literals
  • Loading branch information
@4garfield
4garfield committed Jul 16, 2017
commit 785b0d93a2b2385ed52bff5179a91ff72126437a
6 changes: 3 additions & 3 deletions test/async-hooks/test-signalwrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ assert.strictEqual(typeof signal1.triggerAsyncId, 'number');
checkInvocations(signal1, { init: 1 }, 'when SIGUSR2 handler is set up');

let count = 0;
exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);

let signal2;

Expand All @@ -36,7 +36,7 @@ function onsigusr2() {
' signal1: when first SIGUSR2 handler is called for the first time');

// trigger same signal handler again
exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);
} else {
// second invocation
checkInvocations(
Expand All @@ -61,7 +61,7 @@ function onsigusr2() {
signal2, { init: 1 },
'signal2: when second SIGUSR2 handler is setup');

exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);
}
}

Expand Down