Skip to content

test: add common.mustCall #14262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Suixinlei wants to merge 3 commits into from
Closed

test: add common.mustCall #14262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a86f01
test: add common.mustCall
Jul 16, 2017
3a86bee
test: remove exit handler & add common.mustCall
Jul 16, 2017
3e49f9c
test: simplify common.mustCall
Suixinlei Jul 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add common.mustCall
  • Loading branch information
笑斌 committed Jul 16, 2017
commit 2a86f01f49abe6f0daa3335b9207fb61668075a3
16 changes: 10 additions & 6 deletions test/parallel/test-http-server-keep-alive-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ function run() {

test(function serverEndKeepAliveTimeoutWithPipeline(cb) {
let requestCount = 0;
process.on('exit', () => {
assert.strictEqual(requestCount, 3);
});
const server = http.createServer((req, res) => {
requestCount++;
res.end();
});
server.listen(0, common.mustCall(() => {
process.on('exit', () => {
assert.strictEqual(requestCount, 3);
});
}));
server.setTimeout(500, common.mustCall((socket) => {
// End this test and call `run()` for the next test (if any).
socket.destroy();
Expand All @@ -50,12 +52,14 @@ test(function serverEndKeepAliveTimeoutWithPipeline(cb) {

test(function serverNoEndKeepAliveTimeoutWithPipeline(cb) {
let requestCount = 0;
process.on('exit', () => {
assert.strictEqual(requestCount, 3);
});
const server = http.createServer((req, res) => {
requestCount++;
});
server.listen(0, common.mustCall(() => {
process.on('exit', () => {
assert.strictEqual(requestCount, 3);
});
}));
server.setTimeout(500, common.mustCall((socket) => {
// End this test and call `run()` for the next test (if any).
socket.destroy();
Expand Down
16 changes: 10 additions & 6 deletions test/parallel/test-https-server-keep-alive-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@ function run() {

test(function serverKeepAliveTimeoutWithPipeline(cb) {
let requestCount = 0;
process.on('exit', function() {
assert.strictEqual(requestCount, 3);
});
const server = https.createServer(serverOptions, (req, res) => {
requestCount++;
res.end();
});
server.listen(0, common.mustCall(() => {
process.on('exit', function() {
assert.strictEqual(requestCount, 3);
});
}));
server.setTimeout(500, common.mustCall((socket) => {
// End this test and call `run()` for the next test (if any).
socket.destroy();
Expand All @@ -60,12 +62,14 @@ test(function serverKeepAliveTimeoutWithPipeline(cb) {

test(function serverNoEndKeepAliveTimeoutWithPipeline(cb) {
let requestCount = 0;
process.on('exit', () => {
assert.strictEqual(requestCount, 3);
});
const server = https.createServer(serverOptions, (req, res) => {
requestCount++;
});
server.listen(0, common.mustCall(() => {
process.on('exit', function() {
assert.strictEqual(requestCount, 3);
});
}));
server.setTimeout(500, common.mustCall((socket) => {
// End this test and call `run()` for the next test (if any).
socket.destroy();
Expand Down