Skip to content

doc: fixes default shell in child_process.md #14203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henryzxu wants to merge 7 commits into from
Closed

doc: fixes default shell in child_process.md #14203

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a07c2a
doc: fixes default shell in child_process.md
henryzxu Jul 12, 2017
e9089d3
doc: fixes default shell in child_process.md
henryzxu Jul 12, 2017
a6a073c
doc: fixes default shell in child_process.md
henryzxu Jul 12, 2017
fd92d17
doc: fixes default shell in child_process.md
henryzxu Jul 17, 2017
33adbeb
doc: fixes default shell in child_process.md
henryzxu Jul 17, 2017
e4171c3
doc: fixes default shell in child_process.md
henryzxu Jul 18, 2017
46a8829
doc: fixes default shell in child_process.md
henryzxu Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fixes default shell in child_process.md 
Clarifies that the default shell in Windows is process.env.ComSpec
and that cmd.exe is only used as a fallback. Functions whose
descriptions are affected include:
child_process.spawn, child_process.exec,
child_process.spawnSync, and child_process.execSync.

Fixes: #14156
  • Loading branch information
@henryzxu
henryzxu committed Jul 12, 2017
commit e9089d30566ecff4a98f235de80dd8328c03f806
8 changes: 4 additions & 4 deletions doc/api/child_process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,8 @@ changes:
* `shell` {boolean|string} If `true`, runs `command` inside of a shell. Uses
`'/bin/sh'` on UNIX, and `'process.env.ComSpec'` on Windows. If
`'process.env.ComSpec'` is unavailable, uses `'cmd.exe'` on Windows instead.
A different shell can be specified as a string. The shell should understand
the `-c` switch on UNIX, or `/d /s /c` on Windows. Defaults to `false` (no shell).
A different shell can be specified as a string. The shell should understand the
`-c` switch on UNIX, or `/d /s /c` on Windows. Defaults to `false` (no shell).
* Returns: {ChildProcess}

The `child_process.spawn()` method spawns a new process using the given
Expand Down Expand Up @@ -780,8 +780,8 @@ changes:
* `shell` {boolean|string} If `true`, runs `command` inside of a shell. Uses
`'/bin/sh'` on UNIX, and `'process.env.ComSpec'` on Windows. If
`'process.env.ComSpec'` is unavailable, uses `'cmd.exe'` on Windows instead.
A different shell can be specified as a string. The shell should understand
the `-c` switch on UNIX, or `/d /s /c` on Windows. Defaults to `false` (no shell).
A different shell can be specified as a string. The shell should understand the
`-c` switch on UNIX, or `/d /s /c` on Windows. Defaults to `false` (no shell).
* Returns: {Object}
* `pid` {number} Pid of the child process
* `output` {Array} Array of results from stdio output
Expand Down