Skip to content

test: reduce test-benchmark-net run duration #14183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: reduce test-benchmark-net run duration #14183

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6143a60
test: reduce test-benchmark-net run duration
Trott Jul 12, 2017
5c91bef
squash: additional improvements
Trott Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: reduce test-benchmark-net run duration 
Set configuration option to reduce combinations of benchmark settings
tried in test, reducing execution time by about 50%.
  • Loading branch information
@Trott
Trott committed Jul 12, 2017
commit 6143a60127e1356bd24c50ae140bbbd3eb71f208
5 changes: 4 additions & 1 deletion test/sequential/test-benchmark-net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ const path = require('path');

const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js');

const child = fork(runjs, ['--set', 'dur=0', 'net'],
const child = fork(runjs,
['--set', 'dur=0',
'--set', 'type=buf',
'net'],
{env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}});
child.on('exit', (code, signal) => {
assert.strictEqual(code, 0);
Expand Down