Skip to content

lib: improve lazy loading #14167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 4 commits into from
Closed

lib: improve lazy loading #14167

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59559ca
internal/errors: remove obsolete lazy assert
BridgeAR Jul 11, 2017
a2e95aa
lib: improve lazy requires
BridgeAR Jul 11, 2017
34732c6
fixup: add comment
BridgeAR Jul 18, 2017
9b657aa
fixup: move a statement
BridgeAR Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: add comment
  • Loading branch information
@BridgeAR
BridgeAR committed Jul 18, 2017
commit 34732c6076db438f2fdb026aada95e0b5ba05165
3 changes: 2 additions & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ const nextTick = require('internal/process/next_tick').nextTick;
const errors = require('internal/errors');
const dns = require('dns');

// Lazily loaded
// `cluster` is only used by `listenInCluster` so for startup performance
// reasons it's lazy loaded.
var cluster = null;
Copy link
Copy Markdown
Member Author

@BridgeAR BridgeAR Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be required up front as well but cluster is likely not required in many places that use net and therefore I kept it as is.

Copy link
Copy Markdown
Contributor

@refack refack Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So could you document that:

// `cluster` is only used by `listenInCluster` so for startup performance
// reasons it's lazy loaded.


const errnoException = util._errnoException;
Expand Down