Skip to content

[v8.x] async_hooks: C++ Embedder API overhaul #14109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

[v8.x] async_hooks: C++ Embedder API overhaul #14109

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3685f04
async_hooks: C++ Embedder API overhaul
AndreasMadsen Jul 6, 2017
85597ca
[squash] ABI/API compat
addaleax Jul 6, 2017
a2f61c4
[squash] add deprecation warnings for deprecated MakeCallbacks
addaleax Jul 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] add deprecation warnings for deprecated MakeCallbacks
  • Loading branch information
@addaleax
addaleax committed Jul 11, 2017
commit a2f61c41999159cba21797d23dd8673a1f7af0c9
45 changes: 24 additions & 21 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,29 +613,32 @@ v8::MaybeLocal<v8::Value> MakeCallback(v8::Isolate* isolate,
// Legacy, Node 8.x only.

NODE_EXTERN
v8::MaybeLocal<v8::Value> MakeCallback(v8::Isolate* isolate,
v8::Local<v8::Object> recv,
v8::Local<v8::Function> callback,
int argc,
v8::Local<v8::Value>* argv,
async_id asyncId,
async_id triggerAsyncId);
NODE_DEPRECATED("Use MakeCallback(..., async_context asyncContext) instead",
v8::MaybeLocal<v8::Value> MakeCallback(v8::Isolate* isolate,
v8::Local<v8::Object> recv,
v8::Local<v8::Function> callback,
int argc,
v8::Local<v8::Value>* argv,
async_id asyncId,
async_id triggerAsyncId));
NODE_EXTERN
v8::MaybeLocal<v8::Value> MakeCallback(v8::Isolate* isolate,
v8::Local<v8::Object> recv,
const char* method,
int argc,
v8::Local<v8::Value>* argv,
async_id asyncId,
async_id triggerAsyncId);
NODE_DEPRECATED("Use MakeCallback(..., async_context asyncContext) instead",
v8::MaybeLocal<v8::Value> MakeCallback(v8::Isolate* isolate,
v8::Local<v8::Object> recv,
const char* method,
int argc,
v8::Local<v8::Value>* argv,
async_id asyncId,
async_id triggerAsyncId));
NODE_EXTERN
v8::MaybeLocal<v8::Value> MakeCallback(v8::Isolate* isolate,
v8::Local<v8::Object> recv,
v8::Local<v8::String> symbol,
int argc,
v8::Local<v8::Value>* argv,
async_id asyncId,
async_id triggerAsyncId);
NODE_DEPRECATED("Use MakeCallback(..., async_context asyncContext) instead",
v8::MaybeLocal<v8::Value> MakeCallback(v8::Isolate* isolate,
v8::Local<v8::Object> recv,
v8::Local<v8::String> symbol,
int argc,
v8::Local<v8::Value>* argv,
async_id asyncId,
async_id triggerAsyncId));

/* Helper class users can optionally inherit from. If
* `AsyncResource::MakeCallback()` is used, then all four callbacks will be
Expand Down