Skip to content

lib: use consistent indentation for ternaries #14078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 5 commits into from
Closed

lib: use consistent indentation for ternaries #14078

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49336e1
lib: use consistent indentation for ternaries
Trott Jul 5, 2017
88e6138
squash: address mscdex nit
Trott Jul 5, 2017
c915b7e
squash: first nit from refack
Trott Jul 5, 2017
5da6124
squash: second refack nit
Trott Jul 5, 2017
a1f4bfb
squash: address third refack nit
Trott Jul 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: second refack nit
  • Loading branch information
@Trott
Trott committed Jul 7, 2017
commit 5da6124a3a0f3512656dec99bca7e118fa984e89
7 changes: 3 additions & 4 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,10 +395,9 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
this.query = Object.create(null);
}

var firstIdx =
questionIdx !== -1 && (hashIdx === -1 || questionIdx < hashIdx) ?
questionIdx :
hashIdx;
const useQuestionIdx =
questionIdx !== -1 && (hashIdx === -1 || questionIdx < hashIdx);
const firstIdx = useQuestionIdx ? questionIdx : hashIdx;
if (firstIdx === -1) {
if (rest.length > 0)
this.pathname = rest;
Expand Down