Skip to content

async_hooks: simplify fatalError #14051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasMadsen wants to merge 5 commits into from
Closed

async_hooks: simplify fatalError #14051

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17aafd7
async_hooks: simplify fatalError
AndreasMadsen Jul 3, 2017
278b163
[squash] use try finally, for better stack traces
AndreasMadsen Jul 3, 2017
610d365
[squash] ensure that uncaughtException listeners are removed
AndreasMadsen Jul 3, 2017
1d3f69b
[squash] async_hooks c++ already have a try finally for each hook
AndreasMadsen Jul 3, 2017
527a4f6
[squash] add frindly comment explaining _events interaction
AndreasMadsen Jul 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] add frindly comment explaining _events interaction
  • Loading branch information
@AndreasMadsen
AndreasMadsen committed Jul 3, 2017
commit 527a4f687384d41b36d28189f61b67b4998f9582
2 changes: 2 additions & 0 deletions lib/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ async_wrap.setupHooks({ init,
// in C++.
function clearFatalExceptionHandlers(e) {
process.domain = undefined;
// Don't use removeAllListeners in case there is a removeListener listener
// that would revert it.
process._events.uncaughtException = undefined;
}

Expand Down