Skip to content

tools: fix tools/addon-verify.js #14048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
Closed

tools: fix tools/addon-verify.js #14048

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed7637d
tools: fix tools/addon-verify.js
danbev Jul 3, 2017
347321e
doc: remove undef NDEBUG from addons.md
danbev Jul 3, 2017
3731f60
doc: fix order of AtExit callbacks in addons.md
danbev Jul 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: remove undef NDEBUG from addons.md 
When working on commit 0d95a0b
("test: remove undef NDEBUG from at-exit addons test) I searched for
usages of undef NDEBUG but did not include the doc directory (but I did
include the test directory) and missed this one.

Commit 1f02569f8db9cb0101807df4982534738f0161b2 ("tools: fix
tools/addon-verify.js") enables the code in the "AtExit" section to be
included in the test/addons diretory and this code will again be
tested.
  • Loading branch information
@danbev
danbev committed Aug 7, 2017
commit 347321e1cc4ccad5cc13313f61a96d0e8bcde1e9
1 change: 0 additions & 1 deletion doc/api/addons.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,6 @@ The following `addon.cc` implements AtExit:

```cpp
// addon.cc
#undef NDEBUG
#include <assert.h>
#include <stdlib.h>
#include <node.h>
Expand Down