Skip to content

test: increase --stack-size to prevent child process failure on ARM #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvagg wants to merge 1 commit into from
Closed

test: increase --stack-size to prevent child process failure on ARM #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: increase --stack-size to prevent child process failure on ARM 
On ARM, we get a "Maximum call stack size exceeded" when using
require() in the child process, bump it up a bit to avoid the
failures so we can test what we are actually after
  • Loading branch information
@rvagg
rvagg committed Nov 29, 2014
commit c07fb25643b6973e2d54b9ee4d8cb06d9e23b4bc
2 changes: 1 addition & 1 deletion test/simple/test-child-process-fork-exec-argv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ if (process.argv[2] === 'fork') {
} else if (process.argv[2] === 'child') {
fork(__filename, ['fork']);
} else {
var execArgv = ['--harmony_proxies', '--stack-size=64'];
var execArgv = ['--harmony_proxies', '--stack-size=256'];
var args = [__filename, 'child', 'arg0'];

var child = spawn(process.execPath, execArgv.concat(args));
Expand Down
2 changes: 1 addition & 1 deletion test/simple/test-process-exec-argv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ var spawn = require('child_process').spawn;
if (process.argv[2] === 'child') {
process.stdout.write(JSON.stringify(process.execArgv));
} else {
var execArgv = ['--harmony_proxies', '--stack-size=64'];
var execArgv = ['--harmony_proxies', '--stack-size=256'];
var args = [__filename, 'child', 'arg0'];
var child = spawn(process.execPath, execArgv.concat(args));
var out = '';
Expand Down