Skip to content

assert: improve performance #13973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
Closed

assert: improve performance #13973

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7727eeb
benchmark: fix and extend assert benchmarks
BridgeAR Jun 28, 2017
a3e6194
assert: refactor to reduce unecessary code paths
BridgeAR Jun 28, 2017
6e456f1
test: remove obsolete argument
BridgeAR Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assert: refactor to reduce unecessary code paths 
The lazy loading is not needed as the errors themself lazy
load assert. Therefore the circle is working as intended
even without this lazy loading.

Improve Array, object, ArrayBuffer, Set and Map performance
in all deepEqual checks by removing unecessary code paths and
by moving expensive checks further back.

Improve throws and doesNotThrow performance by removing dead
code and simplifying the overall logic.
  • Loading branch information
@BridgeAR
BridgeAR committed Jul 8, 2017
commit a3e619466f4c23e7c4ae845b5e06066dd2f1319a
Loading