Skip to content

test: add test to verify ErrnoException path #13958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

test: add test to verify ErrnoException path #13958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5f2c51
test: add test to verify ErrnoException path
danbev Jun 30, 2017
32a3027
squash: make test.js follow test style guidelines
danbev Aug 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add test to verify ErrnoException path 
This commit adds a test to verify that the path argument to
ErrnoException can contain UTF-8 characters.
  • Loading branch information
@danbev
danbev committed Aug 13, 2017
commit b5f2c5109adddb90ada2159f8bc6a428a186b4dc
18 changes: 18 additions & 0 deletions test/addons/errno-exception/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#include <node.h>
#include <v8.h>

void Method(const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::Isolate* isolate = args.GetIsolate();
v8::HandleScope scope(isolate);
args.GetReturnValue().Set(node::ErrnoException(isolate,
10,
"syscall",
"some error msg",
"päth"));
}

void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "errno", Method);
}

NODE_MODULE(binding, init)
9 changes: 9 additions & 0 deletions test/addons/errno-exception/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
}
]
}
9 changes: 9 additions & 0 deletions test/addons/errno-exception/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';
const common = require('../../common');
const assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
const err = binding.errno();
assert.strictEqual(err.syscall, 'syscall');
Copy link
Copy Markdown
Member

@gibfahn gibfahn Aug 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit time (from the guide)...

'use strict';

const common = require('../../common');

// Verify that the path argument to node::ErrnoException() can contain UTF-8
// characters.

const assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
const err = binding.errno();

assert.strictEqual(err.syscall, 'syscall');
assert.strictEqual(err.errno, 10);
assert.strictEqual(err.path, 'päth');

Copy link
Copy Markdown
Contributor Author

@danbev danbev Aug 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll update this.

assert.strictEqual(err.errno, 10);
assert.strictEqual(err.path, 'päth');
Copy link
Copy Markdown
Member

@addaleax addaleax Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a tiny suggestion, maybe check err.message as well :)

Copy link
Copy Markdown
Contributor Author

@danbev danbev Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes :) Thanks

assert.ok(/^Error:\s\w+, some error msg 'päth'$/.test(err.toString()));