Skip to content

test: remove require('buffer') on 4 test files #13846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leizongmin wants to merge 1 commit into from
Closed

test: remove require('buffer') on 4 test files #13846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove require('buffer') on 4 test files 
* test/parallel/test-buffer-fakes.js
* test/parallel/test-buffer-includes.js
* test/parallel/test-buffer-indexof.js
* test/parallel/test-buffer-new.js

Refs: #13836
  • Loading branch information
@leizongmin
leizongmin committed Jun 21, 2017
commit cd0357bc84b7a14aa9613e3e3db388f6b5a6cce9
1 change: 0 additions & 1 deletion test/parallel/test-buffer-fakes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

require('../common');
const assert = require('assert');
const Buffer = require('buffer').Buffer;

function FakeBuffer() { }
Object.setPrototypeOf(FakeBuffer, Buffer);
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-buffer-includes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
const common = require('../common');
const assert = require('assert');

const Buffer = require('buffer').Buffer;

const b = Buffer.from('abcdef');
const buf_a = Buffer.from('a');
const buf_bc = Buffer.from('bc');
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-buffer-indexof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
require('../common');
const assert = require('assert');

const Buffer = require('buffer').Buffer;

const b = Buffer.from('abcdef');
const buf_a = Buffer.from('a');
const buf_bc = Buffer.from('bc');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-buffer-new.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@

require('../common');
const assert = require('assert');
const Buffer = require('buffer').Buffer;

assert.throws(() => new Buffer(42, 'utf8'), /first argument must be a string/);